ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r428788807
########## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreSourceImpl.java ########## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import java.util.concurrent.atomic.AtomicBoolean; + +import org.apache.hadoop.hbase.metrics.Counter; +import org.apache.hadoop.hbase.metrics.Interns; +import org.apache.hadoop.hbase.metrics.MetricRegistry; +import org.apache.hadoop.metrics2.MetricsRecordBuilder; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@InterfaceAudience.Private +public class MetricsStoreSourceImpl implements MetricsStoreSource { + + private MetricsStoreWrapper storeWrapper; + private MetricsStoreAggregateSourceImpl aggreagate; + private AtomicBoolean closed = new AtomicBoolean(false); + + private String storeNamePrefix; + private final MetricRegistry registry; + private static final Logger LOG = LoggerFactory.getLogger(MetricsStoreSourceImpl.class); + String storeReadsKey; + + String memstoreReadsKey; + String fileReadsKey; + private final Counter storeReads; + private final Counter memstoreReads; + private final Counter fileReads; + + public MetricsStoreSourceImpl(MetricsStoreWrapper storeWrapper, + MetricsStoreAggregateSourceImpl aggreagate) { + this.storeWrapper = storeWrapper; + this.aggreagate = aggreagate; + aggreagate.register(this); + + LOG.debug("Creating new MetricsRegionSourceImpl for table " + storeWrapper.getStoreName() + " " + + storeWrapper.getRegionName()); + + // we are using the hbase-metrics API + registry = aggreagate.getMetricRegistry(); + + storeNamePrefix = "Namespace_" + storeWrapper.getNamespace() + "_table_" + + storeWrapper.getTableName() + "_region_" + storeWrapper.getRegionName() + "_store_" + + storeWrapper.getStoreName() + "_metric_"; + + String suffix = "Count"; + + storeReadsKey = storeNamePrefix + MetricsRegionServerSource.GET_KEY + suffix; + // all the counters are hbase-metrics API + storeReads = registry.counter(storeReadsKey); + + memstoreReadsKey = storeNamePrefix + MetricsRegionServerSource.MEMSTORE_GET_KEY + suffix; + memstoreReads = registry.counter(memstoreReadsKey); + + fileReadsKey = storeNamePrefix + MetricsRegionServerSource.FILE_GET_KEY + suffix; + fileReads = registry.counter(fileReadsKey); + + } + + @Override + public void close() { + boolean wasClosed = closed.getAndSet(true); + + // Has someone else already closed this for us? + if (wasClosed) { + return; + } + + // Before removing the metrics remove this region from the aggregate region bean. + // This should mean that it's unlikely that snapshot and close happen at the same time. + aggreagate.deregister(this); + + // While it's un-likely that snapshot and close happen at the same time it's still possible. + // So grab the lock to ensure that all calls to snapshot are done before we remove the metrics + synchronized (this) { + if (LOG.isTraceEnabled()) { + LOG.trace("Removing store Metrics: " + storeWrapper.getStoreName()); + } + + registry.remove(storeReadsKey); + registry.remove(memstoreReadsKey); + registry.remove(fileReadsKey); + + storeWrapper = null; + } + } + + @Override + public int compareTo(MetricsStoreSource source) { + if (!(source instanceof MetricsStoreSourceImpl)) { + return -1; + } + + MetricsStoreSourceImpl impl = (MetricsStoreSourceImpl) source; + if (impl == null) { + return -1; + } + + // TODO : make this better + return Long.compare(this.storeWrapper.getStoreName().hashCode(), + impl.storeWrapper.getStoreName().hashCode()); + } + + @Override + public void updateGet() { + storeReads.increment(); + } + + @Override + public void updateMemtoreGet() { + memstoreReads.increment(); + } + + @Override + public void updateFileGet() { + fileReads.increment(); + } + + @Override + public boolean equals(Object obj) { + return obj == this + || (obj instanceof MetricsStoreSourceImpl && compareTo((MetricsStoreSourceImpl) obj) == 0); + } + + @Override + public int hashCode() { + return this.storeWrapper.getStoreName().hashCode(); + } + + void snapshot(MetricsRecordBuilder mrb, boolean ignored) { + + // If there is a close that started be double extra sure + // that we're not getting any locks and not putting data + // into the metrics that should be removed. So early out + // before even getting the lock. + if (closed.get()) { + return; + } + + // Grab the read + // This ensures that removes of the metrics + // can't happen while we are putting them back in. + synchronized (this) { + + // It's possible that a close happened between checking + // the closed variable and getting the lock. + if (closed.get()) { + return; + } + mrb.addGauge(Interns.info(storeNamePrefix + MetricsRegionServerSource.STOREFILE_COUNT, Review comment: At region level we had the aggregation across stores. Here it is per store. Just aggregation . We don do anything here to evaluate all this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
