wchevreuil commented on a change in pull request #2255:
URL: https://github.com/apache/hbase/pull/2255#discussion_r475551956
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java
##########
@@ -290,7 +290,22 @@ private boolean updateLogPosition(WALEntryBatch batch) {
public void startup(UncaughtExceptionHandler handler) {
String name = Thread.currentThread().getName();
Threads.setDaemonThreadRunning(this,
- name + ".replicationSource.shipper" + walGroupId + "," +
source.getQueueId(), handler);
+ name + ".replicationSource.shipper" + walGroupId + "," +
source.getQueueId(),
+ (t,e) -> {
Review comment:
Moved it to _uncaughtException_. This is true when handling potential
errors on both the reader and shipper threads, but _uncaughtException_ is also
used when handling issues from _ReplicationSource.initialize_ method, which
might blow before reader/shipper is even started. So needed to add extra check
in _uncaughtException_ to decide when to invoke _refreshSources_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
