wchevreuil commented on a change in pull request #2255:
URL: https://github.com/apache/hbase/pull/2255#discussion_r475666601
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -119,6 +120,14 @@
private int logQueueWarnThreshold;
// ReplicationEndpoint which will handle the actual replication
private volatile ReplicationEndpoint replicationEndpoint;
+ //This is needed for the startup loop to identify when there's already
+ // an initialization happening (but not finished yet),
+ // so that it doesn't try submit another initialize thread.
+ // NOTE: this should only be set to false at the end of initialize method,
prior to return.
+// private final AtomicBoolean startupOngoing = new AtomicBoolean(false);
Review comment:
Actually, this whole block can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
