wchevreuil commented on a change in pull request #2255:
URL: https://github.com/apache/hbase/pull/2255#discussion_r475665485
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -587,12 +617,25 @@ private void initialize() {
@Override
public void startup() {
- // mark we are running now
- this.sourceRunning = true;
- initThread = new Thread(this::initialize);
- Threads.setDaemonThreadRunning(initThread,
- Thread.currentThread().getName() + ".replicationSource," + this.queueId,
- this::uncaughtException);
+ //Flag that signalizes uncaught error happening while starting up the
source
+ // and a retry should be attempted
+ AtomicBoolean retryStartup = new AtomicBoolean(false);
Review comment:
It's been modified by the lambda expression on line #635, since lambdas
expressions requires variables to be final, I can't use a simple, local
primitive boolean or wrapper.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -587,12 +617,25 @@ private void initialize() {
@Override
public void startup() {
- // mark we are running now
- this.sourceRunning = true;
- initThread = new Thread(this::initialize);
- Threads.setDaemonThreadRunning(initThread,
- Thread.currentThread().getName() + ".replicationSource," + this.queueId,
- this::uncaughtException);
+ //Flag that signalizes uncaught error happening while starting up the
source
+ // and a retry should be attempted
+ AtomicBoolean retryStartup = new AtomicBoolean(false);
Review comment:
It's been modified by the lambda expression on line #635, since lambdas
expressions require variables to be final, I can't use a simple, local
primitive boolean or wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
