apurtell commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-686694208
I was so focused on limit that I didn't see the other issues here too,
although this idea was reflected in other feedback.
The Admin API should be fully generic:
List<LogEntry> getLogEntries(ServerName server, LogName log, int (or
long) limit) throws IOException;
One method to ask any server, either master or regionserver, for any log of
any name (with a limit 😃 ) Does that help clarify things? This is why I made
the other comment about the RPC level changes. No special case RPC to the
master for BalancerLog specifically. One generic facility to ask any server for
the entries of any named ring.
So going forward we can add a ring anywhere for any reason and not need to
change Public/Stable API, nor define new RPC methods for same.
Now, we may want to add *additional* convenience classes in
org.apache.hadoop.hbase.client.* , but the client-server API would be
unaffected by changes to this sugar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
