ddupg commented on a change in pull request #2521:
URL: https://github.com/apache/hbase/pull/2521#discussion_r503638903
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##########
@@ -475,7 +476,7 @@ public boolean replicate(ReplicateContext replicateContext)
{
}
List<List<Entry>> batches = createBatches(replicateContext.getEntries());
- while (this.isRunning() && !exec.isShutdown()) {
+ while (this.isRunning() && !exec.isShutdown() &&
!Thread.currentThread().isInterrupted()) {
Review comment:
How about using `ReplicationSource.isSourceActive()` instead of
`!Thread.currentThread().isInterrupted()` ? HBaseReplicationEndpoint manages
lifecycle by extent `AbstractService`, adding a flag in
HBaseInterClusterReplicationEndpoint is a bit redundant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
