ddupg commented on a change in pull request #2521:
URL: https://github.com/apache/hbase/pull/2521#discussion_r504359216
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -691,6 +691,9 @@ public void terminate(String reason, Exception cause,
boolean clearMetrics,
}
}
+ if (this.replicationEndpoint != null) {
Review comment:
> But it is still a bit strange that, the above stop worker and
setReaderRunning to false can not stop the work?
Yes, stop worker and setReaderRunning to false just set flag non-running, if
happens exception in while loop of method replicationEndpoint.replicate, will
go into retry and cannot sense the flag changing. Leaving the retry can be
achieved by calling replicationEndpoint.stop().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
