infraio commented on a change in pull request #2521:
URL: https://github.com/apache/hbase/pull/2521#discussion_r503649422
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -691,6 +691,9 @@ public void terminate(String reason, Exception cause,
boolean clearMetrics,
}
}
+ if (this.replicationEndpoint != null) {
Review comment:
ReplicationSourceShipper and entryReader are thread. replicationEndpoint
is not a thread and is used by ReplicationSourceShipper thread. I am +1 for
this: stop firstly, then interrupt thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
