anoopsjohn commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r508268448
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -9143,4 +9162,8 @@ public void setReadRequestsCount(long readRequestsCount) {
public void setWriteRequestsCount(long writeRequestsCount) {
this.writeRequestsCount.add(writeRequestsCount);
}
+
+ public void setFullScanRequestsCount(long fullScanRequestsCount) {
Review comment:
Not used. Do we need this setter?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3498,6 +3501,12 @@ public ScanResponse scan(final RpcController controller,
final ScanRequest reque
throw new ServiceException(e);
}
HRegion region = rsh.r;
+ // If the start row is the actual start Row of the region and end row is
actual end row of region
+ // or
+ // If the stop is not specified or the stop Row is greater than the end
key of the current region
+ if(!region.getRegionInfo().getTable().isSystemTable()){
Review comment:
Nit : missing code formatting
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
##########
@@ -23,6 +23,7 @@
import org.apache.hadoop.hbase.Cell;
import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
Review comment:
Unused import
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -7238,6 +7246,9 @@ public boolean nextRaw(List<Cell> outResults,
ScannerContext scannerContext)
rsServices.getMetrics().updateReadQueryMeter(getRegionInfo().getTable());
}
+ if(isFullRegionScan()) {
Review comment:
nit format
if (isFullRegionScan()) {
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -7699,6 +7710,14 @@ public void run() throws IOException {
// callback
this.close();
}
+
+ public boolean isFullRegionScan() {
Review comment:
Can be private now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
