anoopsjohn commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r509142973
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -3075,6 +3080,13 @@ private RegionScannerImpl getScanner(Scan scan,
List<KeyValueScanner> additional
checkFamily(family);
}
}
+ if((Bytes.equals(scan.getStartRow(), getRegionInfo().getStartKey())
Review comment:
Can add a comment saying what all we count as full scan.. the check is
bit complex,.. So nice code level comment helps.. Also we can do this boolean
eval at create of scan itself and use that boolean state? No need to do all
thse bytes[] checks for every next() call?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
