anoopsjohn commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r521837369
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1336,14 +1342,31 @@ private RegionScannerHolder addScanner(String
scannerName, RegionScanner s, Ship
} else {
closeCallback = new RegionScannerCloseCallBack(s);
}
+
Review comment:
Nit: whitespace lines
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3164,7 +3187,14 @@ private RegionScannerHolder newRegionScanner(ScanRequest
request, ScanResponse.B
builder.setMvccReadPoint(scanner.getMvccReadPoint());
builder.setTtl(scannerLeaseTimeoutPeriod);
String scannerName = String.valueOf(scannerId);
- return addScanner(scannerName, scanner, shipper, region,
scan.isNeedCursorResult());
+
+ boolean isFullRegionScan = false;
+ if(!region.getRegionInfo().getTable().isSystemTable()) {
Review comment:
nit : format missing. there should be a space between if and (
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3481,6 +3512,9 @@ public ScanResponse scan(final RpcController controller,
final ScanRequest reque
}
throw new ServiceException(e);
}
+ if(rsh.isFullRegionScan) {
+ rpcFullScanRequestCount.increment();
Review comment:
Nit : if( -> if (
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1336,14 +1342,31 @@ private RegionScannerHolder addScanner(String
scannerName, RegionScanner s, Ship
} else {
closeCallback = new RegionScannerCloseCallBack(s);
}
+
+
+
RegionScannerHolder rsh =
- new RegionScannerHolder(scannerName, s, r, closeCallback,
shippedCallback, needCursor);
+ new RegionScannerHolder(scannerName, s, r, closeCallback,
shippedCallback, needCursor, isFullRegionScan);
Review comment:
nit: Format line so that max length is 100
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3164,7 +3187,14 @@ private RegionScannerHolder newRegionScanner(ScanRequest
request, ScanResponse.B
builder.setMvccReadPoint(scanner.getMvccReadPoint());
builder.setTtl(scannerLeaseTimeoutPeriod);
String scannerName = String.valueOf(scannerId);
- return addScanner(scannerName, scanner, shipper, region,
scan.isNeedCursorResult());
+
+ boolean isFullRegionScan = false;
+ if(!region.getRegionInfo().getTable().isSystemTable()) {
Review comment:
BTW this can be single line simply
boolean isFullRegionScan =
!region.getRegionInfo().getTable().isSystemTable() && checkFullRegionScan(scan,
region);
checkFullRegionScan -> isFullRegionScan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
