[ 
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249534#comment-17249534
 ] 

ramkrishna.s.vasudevan commented on HBASE-24850:
------------------------------------------------

bq.Can we have compare(Cell) in ExtendedCell? 

Yes I looked into this option. What it will end up finally is that say if KV 
implements this compare(Cell). Now if the current cell (as pointed by 'this') 
and the incoming Cell are KVs ya we can handle it in KV. But if the incoming 
cell is BBKV then it means 'this' (referring to KV) needs to compare with BBKV. 
Then we should add that logic inside the compare(Cell) of KV. So it would be 
better to move such things to an Util method. that is why I felt that 
redirection from compare() to that Util method is not needed. 

> CellComparator perf improvement
> -------------------------------
>
>                 Key: HBASE-24850
>                 URL: https://issues.apache.org/jira/browse/HBASE-24850
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance, scan
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> We have multiple perf issues in 2.x versions compared to 1.x.  Eg: 
> HBASE-24754, HBASE-24637.
> The pattern is clear that where ever we do more and more Cell compares, there 
> is some degrade.   In HBASE-24754, with an old KVComparator style comparator, 
> we see much better perf for the PutSortReducer.  (Again the gain is huge 
> because of large number of compare ops that test is doing).  This issue is to 
> address and optimize compares generally in CellComparatorImpl itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to