[
https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250554#comment-17250554
]
Michael Stack commented on HBASE-24850:
---------------------------------------
The flamegraphs help. Thanks. Looks like there are a few dispatches still to
get rid of but the meat of the compare looks inlined; nice. Next up would be
working on the big chunk in the middle in the _opt.svg... trying to make a dent
in the 75% of time spent.
I left comments on the JIRA... suggesting no need of the marker interface since
Cell impls and comparator are all package private.... Thanks.
> CellComparator perf improvement
> -------------------------------
>
> Key: HBASE-24850
> URL: https://issues.apache.org/jira/browse/HBASE-24850
> Project: HBase
> Issue Type: Improvement
> Components: Performance, scan
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: flamegraph.svg, flamegraph_opt.svg, op_withnoopt,
> op_withopt
>
>
> We have multiple perf issues in 2.x versions compared to 1.x. Eg:
> HBASE-24754, HBASE-24637.
> The pattern is clear that where ever we do more and more Cell compares, there
> is some degrade. In HBASE-24754, with an old KVComparator style comparator,
> we see much better perf for the PutSortReducer. (Again the gain is huge
> because of large number of compare ops that test is doing). This issue is to
> address and optimize compares generally in CellComparatorImpl itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
