sandeepvinayak commented on a change in pull request #3347:
URL: https://github.com/apache/hbase/pull/3347#discussion_r643610707
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java
##########
@@ -103,6 +103,12 @@ protected WALEntryFilter getScopeWALEntryFilter() {
/** Returns a WALEntryFilter for checking replication per table and CF.
Subclasses can
* return null if they don't want this filter */
protected WALEntryFilter getNamespaceTableCfWALEntryFilter() {
+ //If none of the below sets are defined, there's no reason to create this
filter
+ if(ctx.getPeerConfig().getNamespaces()==null &&
ctx.getPeerConfig().getTableCFsMap()==null
Review comment:
Should we handle the empty values as well?
`Strings.isNullOrEmpty(strVar)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
