wchevreuil commented on a change in pull request #3347:
URL: https://github.com/apache/hbase/pull/3347#discussion_r644047371
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java
##########
@@ -69,13 +68,14 @@ public void peerConfigUpdated(ReplicationPeerConfig rpc){
@Override
public WALEntryFilter getWALEntryfilter() {
ArrayList<WALEntryFilter> filters = Lists.newArrayList();
- WALEntryFilter scopeFilter = getScopeWALEntryFilter();
- if (scopeFilter != null) {
- filters.add(scopeFilter);
- }
WALEntryFilter tableCfFilter = getNamespaceTableCfWALEntryFilter();
if (tableCfFilter != null) {
filters.add(tableCfFilter);
+ } else {
Review comment:
That would be the case. The given table/CF should be in the namespace
passed, or in the TableCFsMap defined in the addPeer command. It does break
compatibility, but it's still possible to achieve the same level of granularity
by using a combination of
ExcludeTableCFsMap/ExcludeNamespaces/namespaces/TableCFsMap, which is much more
convenient than having to alter table schema (which also requires table to be
offline).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
