wchevreuil commented on a change in pull request #3347:
URL: https://github.com/apache/hbase/pull/3347#discussion_r644059640
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestRemoveFromSerialReplicationPeer.java
##########
@@ -89,14 +93,18 @@ public void testRemoveTable() throws Exception {
waitUntilHasLastPushedSequenceId(region);
UTIL.getAdmin().updateReplicationPeerConfig(PEER_ID,
-
ReplicationPeerConfig.newBuilder(peerConfig).setTableCFsMap(Collections.emptyMap()).build());
+ ReplicationPeerConfig.newBuilder(peerConfig)
+ .setTableCFsMap(Collections.emptyMap())
+ .setReplicateAllUserTables(true)
+ .setExcludeTableCFsMap(ImmutableMap.of(tableName,
Collections.emptyList())).build());
Review comment:
The previous test behaviour isn't valid anymore, as it was relying on an
empty `namespaces` collection to filter out entries, but now, passing null or
empty `namespaces` just activates the scoped filter, which will cause these
table entries to be picked for replication, as its scope is set to `1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
