anoopsjohn commented on a change in pull request #3347:
URL: https://github.com/apache/hbase/pull/3347#discussion_r644450797
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java
##########
@@ -69,13 +68,14 @@ public void peerConfigUpdated(ReplicationPeerConfig rpc){
@Override
public WALEntryFilter getWALEntryfilter() {
ArrayList<WALEntryFilter> filters = Lists.newArrayList();
- WALEntryFilter scopeFilter = getScopeWALEntryFilter();
- if (scopeFilter != null) {
- filters.add(scopeFilter);
- }
WALEntryFilter tableCfFilter = getNamespaceTableCfWALEntryFilter();
if (tableCfFilter != null) {
filters.add(tableCfFilter);
+ } else {
Review comment:
Any way we can avoid the compatibility break? May be a bigger change but
can we think ways? The WALEntryFilter s to act in an OR fashion? The chain is
more or less an AND model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
