virajjasani commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r662167700
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
/**
* Check if normalization enable flag of the table is true. If flag is false
- * then no region normalizer won't attempt to normalize this table.
+ * then region normalizer won't attempt to normalize this table.
*
- * @return true if region normalization is enabled for this table
+ * @return value of NORMALIZATION_ENABLED key for this table if present else
return null
*/
- boolean isNormalizationEnabled();
+ Boolean isNormalizationEnabled();
Review comment:
For IA.Public APIs, we can add new API but should not alter/remove
existing ones without going through deprecation cycle. I am proposing something
like this:
```
@Deprecated
boolean isNormalizationEnabled();
TDNormalizer isNormalizationEnabled();
```
Going from boolean to Boolean introduces null handling that could break
source compatibility and also the behaviour of API changes: instead of
returning `false` if normalizer is not defined in TD, now we are returning
`null`. Hence, this breaks behaviour of existing IA.Public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
