mnpoonia commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r662211134
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
/**
* Check if normalization enable flag of the table is true. If flag is false
- * then no region normalizer won't attempt to normalize this table.
+ * then region normalizer won't attempt to normalize this table.
*
- * @return true if region normalization is enabled for this table
+ * @return value of NORMALIZATION_ENABLED key for this table if present else
return null
*/
- boolean isNormalizationEnabled();
+ Boolean isNormalizationEnabled();
Review comment:
Another way is to move the decision logic to the method in Table
descriptor. i personally don't like that but it make sense since whole idea is
to set the default value of table descript from false to something that can be
set using hbase-default (hbase-site)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
