wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r672932031
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -278,6 +280,21 @@ protected final StoreFileWriter
createTmpWriter(FileDetails fd, boolean shouldDr
HConstants.EMPTY_STRING);
}
+ /**
+ * Default method for initializing a StoreFileWriter in the compaction
process, this creates the
Review comment:
>Is creating them in the temp directory really "default"? Or is it
"default" just because the direct-insert stuff isn't available yet? ;)
It is the default now, if we don't explicitly specify
`hbase.hstore.defaultengine.compactor.class` config property to set
`DirectStoreCompactor` implementation to be used, the previous existing
`DefaultCompactor` will be loaded, which implements this logic.
> When you say other compactors may not use it, it makes me wonder if it
makes sense to provide it here.
What I meant is that other compactors may overwrite the method with a
different logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
