wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r663949806
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1192,7 +1195,7 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
return builder.build();
}
- HFileContext createFileContext(Compression.Algorithm compression,
+ public HFileContext createFileContext(Compression.Algorithm compression,
Review comment:
This one in particular, could had logic duplicated wherever it's needed,
but it's more of a helper method, so didn't think making it public would be
harmful. I can revert it back to package private and re-implement this in the
`DirectStoreCompactor`, if you think this shouldn't be exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
