wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r663966127



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
##########
@@ -278,6 +280,21 @@ protected final StoreFileWriter 
createTmpWriter(FileDetails fd, boolean shouldDr
         HConstants.EMPTY_STRING);
   }
 
+  /**
+   * Default method for initializing a StoreFileWriter in the compaction 
process, this creates the

Review comment:
       StoreEngine delegates the work to a `Compactor` implementation, where 
`DefaultCompator`, the default Compactor implementation, uses this one to 
create the file writer. So that's why we say it's the "default" method. 
Alternatives compactors may not use it, like the `DirectStoreCompactor` that 
implements its own logic that creates the file on the store directory, rather 
than under temp.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to