bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r680877837
##########
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##########
@@ -345,6 +347,12 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.println(MARKER
+ "Log Class: <b>" + log.getClass().getName() +"</b><br />");
if (level != null) {
+ if (!isLogLevelChangeAllowed(logName, readOnlyLogLevels)) {
+ response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED,
Review comment:
Thanks for the pointer. It looks like hbase uses a shaded version of
netty, and further up in this class uses `sendError` to send an error response.
I could change this if I get another vote from an hbase committer, but I
probably should change both in that case. Seems out of scope for this jira, but
can do it if we think I should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
