bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r680902855
##########
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##########
@@ -345,6 +347,12 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.println(MARKER
+ "Log Class: <b>" + log.getClass().getName() +"</b><br />");
if (level != null) {
+ if (!isLogLevelChangeAllowed(logName, readOnlyLogLevels)) {
+ response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED,
Review comment:
@jojochuang I looked more closely, and there are at least 6 servlets
that use the current `sendError` behavior, as well as a couple filters. It
seems like we might want to leave this alone here and instead create a jira to
update all usages so that they are future proof. Or we could fix those issues
as part of a future "upgrade netty" jira.
Does that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
