bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r681759233
##########
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##########
@@ -360,6 +368,18 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.close();
}
+ private boolean isLogLevelChangeAllowed(String logger, String[]
readOnlyLogLevels) {
+ if (readOnlyLogLevels == null) {
+ return true;
+ }
+ for (String readOnlyLogLevel : readOnlyLogLevels) {
+ if (readOnlyLogLevel.startsWith(logger)) {
Review comment:
Good catch. Fixed and added a test.
As you may have anticipated in your original comment about response code
verification, this meant I needed to update LogLevel to use `setStatus` as you
said :). This meant having to validate the response in the CLI, which is used
in in the test. These were minor tweaks, but you'll see them in the latest
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
