bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r685627387
##########
File path: hbase-protocol-shaded/src/main/protobuf/Master.proto
##########
@@ -292,7 +292,8 @@ message IsInMaintenanceModeResponse {
}
message BalanceRequest {
- optional bool force = 1;
+ optional bool ignore_rit = 1;
Review comment:
Yes, the only thing that matters for protobuf is actually the ordinal --
not the position, but the number on the right hand side.
I renamed this so it would reflect the actual functionality of this
argument. The current implementation of `force` only affects the region in
transition behavior. The fact that it's called `force` is opaque and
uninformative, and as part of the move to the more descriptive BalanceRequest
it made sense to rename it.
If you'd prefer I leave it, I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
