bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686000952
##########
File path: hbase-protocol-shaded/src/main/protobuf/Master.proto
##########
@@ -292,7 +292,8 @@ message IsInMaintenanceModeResponse {
}
message BalanceRequest {
- optional bool force = 1;
+ optional bool ignore_rit = 1;
Review comment:
What this could break is if people have custom forks that are directly
accessing the protobufs. I'm assuming the protobufs are
InterfaceAudience.PRIVATE, not sure if that's explicitly documented somewhere.
For anyone who's using the basic Admin interfaces, it will all work with the
rename.
Let me know if you'd prefer me to leave it. It feels much more intuitive to
call it what it is, rather than force. If we ever wanted to add a new
functionality to force, I think we should add a new boolean instead and add it
to the builder. So we'd have like a `ignore_maintenance_mode` and
`setIgnoreMaintenanceMode()` on the BalanceRequest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
