bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r685629015
##########
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##########
@@ -291,17 +292,19 @@ public void removeRSGroup(RpcController controller,
@Override
public void balanceRSGroup(RpcController controller,
BalanceRSGroupRequest request, RpcCallback<BalanceRSGroupResponse>
done) {
+ BalanceRequest balanceRequest =
RSGroupProtobufUtil.toBalanceRequest(request);
+
BalanceRSGroupResponse.Builder builder =
BalanceRSGroupResponse.newBuilder();
LOG.info(master.getClientIdAuditPrefix() + " balance rsgroup, group="
+ request.getRSGroupName());
try {
- if (master.getMasterCoprocessorHost() != null) {
+ if (master.getMasterCoprocessorHost() != null &&
!balanceRequest.isDryRun()) {
Review comment:
The idea here is that the dryRun mode should have no impact on the
cluster, and we can't really guarantee that with a coprocessor. I could add the
dry run argument to the coprocessor, but I imagine that opens another can of
interface worms. I'm fine to add it, I just felt it might cause more issues
than not. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
