bbeaudreault commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-896243584
@ndimiduk thanks for the followup. I've pushed a commit which covers two outcomes from the latest round: - Add BalanceRequest to preBalance/postBalance (and same for rsgroup coprocessor hooks) - Revert RSGroup implementation to use BalanceRequest This leaves just 2 open questions: - Are you ok with my leaving the `ignore_rit` rename in Master.proto? I submitted the DISCUSS thread, but not sure if that's a blocker here. - What are your thoughts on our ability to easily change the new Admin method `boolean balance(BalanceRequest request) throws IOException` to something like `BalanceResponse balance(BalanceRequest request) throws IOException` in the future? If it will be a pain, I could add a lightweight placeholder for now that we can improve on the future. My concern is that changing the return value is a breaking interface change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
