bbeaudreault commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-904136017
Hey all, here's an update: - I've rolled all of the original commits into 1 commit, and included fixes for @ndimiduk's latest review. - I've also added a new commit which adds a BalanceResponse object, as we discussed. I am not sure I'll have time to come back to balancer improvements before 2.5.0, and I wanted to make sure we at least lock in the new IA.Evolving interface in case 2.5.0 ships before I or anyone else can get to it. In this PR, I do not want to go too crazy imagining all of the cool things we can add to the response. The new object has 3 fields: isBalancerRan, getMovesCalculated, getMovesExecuted. I actually think these on there own are useful for operators, so it seems like an OK starting place. I'm not able to run the full test suite right now, so will be keeping an eye on the jenkins build and update if any tests fail. I didn't add an explicit testBalancerResponses test, but I did include assertions about the new fields in some existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
