wchevreuil commented on pull request #3845: URL: https://github.com/apache/hbase/pull/3845#issuecomment-970196967
> > > Do we need to implement rollback where we will delete the partial table directory? > > > > > > We already delete pre-existing table dir on line on line #104. > > This is not the same thing, it is not about retry but about how to clean up the storage when the CreateTableProcedure fails. > > But checked the code, we do not support rollback when we already arrive the WRITE_FS_LAYOUT state, so it should not be a problem. Yeah, thought about adding a rollback logic here, but then thought it wouldn't be necessary as we do the check/cleanup every time in the beginning of the proc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
