Apache9 commented on pull request #3845:
URL: https://github.com/apache/hbase/pull/3845#issuecomment-970372604


   > > The failed UT is related?
   > > TestMasterFileSystem.testCheckTempDir
   > 
   > Yes, it's failing because it can't rename tabledir to temp:
   > 
   > ... 2021-11-16T11:45:56,209 WARN [IPC Server handler 3 on 50183] 
namenode.FSDirRenameOp(182): DIR* FSDirectory.unprotectedRenameTo: failed to 
rename 
/user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/data/default/testCheckTempDir
 to 
/user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/.tmp/data/default/testCheckTempDir
 because destination's parent does not exist ...
   > 
   > I think this UT is invalid now that we don't need table temp dir. I'm 
gonna change it to reflect the current behaviour.
   
   Checked the usage, there are 3 places where we use it, in 
CreateTableProcedure, CloneSnapshotProcedure and 
DeleteTableProcedure.deleteFromFs. Since now we do not use temp directory for 
all these procedures any more, I think we could just remove this temp dir in 
MasterFileSystem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to