Apache9 commented on a change in pull request #3952:
URL: https://github.com/apache/hbase/pull/3952#discussion_r772851451
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
##########
@@ -90,16 +102,33 @@ public void tearDown() throws IOException {
}
private SpanData waitSpan(String name) {
- Waiter.waitFor(CONF, 1000,
- () -> traceRule.getSpans().stream().map(SpanData::getName).anyMatch(s ->
s.equals(name)));
- return traceRule.getSpans().stream().filter(s ->
s.getName().equals(name)).findFirst().get();
+ return waitSpan(hasName(name));
+ }
+
+ private SpanData waitSpan(Matcher<SpanData> matcher) {
+ Matcher<SpanData> spanLocator = allOf(matcher, hasEnded());
+ try {
+ Waiter.waitFor(CONF, 1000, new MatcherPredicate<>(
+ "waiting for span",
+ () -> traceRule.getSpans(), hasItem(spanLocator)));
+ } catch (AssertionError e) {
Review comment:
Why catch AssertionError here?
And at lease, let's use LOG to output the message, not System.err?
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
##########
@@ -117,18 +123,33 @@ private boolean isMeta(TableName tableName) {
}
}
- private List<String> getRegionName(RegionLocations locs) {
- List<String> names = new ArrayList<>();
- for (HRegionLocation loc : locs.getRegionLocations()) {
- if (loc != null) {
- names.add(loc.getRegion().getRegionNameAsString());
- }
+ private static List<String> getRegionNames(RegionLocations locs) {
+ if (locs == null) {
Review comment:
if (locs == null || locs.getRegionLocations() == null)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
