Apache9 commented on a change in pull request #3952:
URL: https://github.com/apache/hbase/pull/3952#discussion_r774244749
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitConnectionRegistry.java
##########
@@ -68,6 +68,11 @@ public
ShortCircuitConnectionRegistry(ConnectionRegistryEndpoint endpoint) {
return future;
}
+ @Override
+ public String getConnectionString() {
+ return "localhost";
Review comment:
Maybe just call it short-circuit? I do not think localhost is accurate
enough, it may implies that we are connecting to a regsitry through network but
on the same machine? For short-circuit we know that we are using the
ShortCircuitConnectionRegistry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
