ndimiduk commented on a change in pull request #3952:
URL: https://github.com/apache/hbase/pull/3952#discussion_r774232183
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
##########
@@ -90,16 +102,33 @@ public void tearDown() throws IOException {
}
private SpanData waitSpan(String name) {
- Waiter.waitFor(CONF, 1000,
- () -> traceRule.getSpans().stream().map(SpanData::getName).anyMatch(s ->
s.equals(name)));
- return traceRule.getSpans().stream().filter(s ->
s.getName().equals(name)).findFirst().get();
+ return waitSpan(hasName(name));
+ }
+
+ private SpanData waitSpan(Matcher<SpanData> matcher) {
+ Matcher<SpanData> spanLocator = allOf(matcher, hasEnded());
+ try {
+ Waiter.waitFor(CONF, 1000, new MatcherPredicate<>(
+ "waiting for span",
+ () -> traceRule.getSpans(), hasItem(spanLocator)));
+ } catch (AssertionError e) {
Review comment:
Oops, this may be some left-over debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
