busbey commented on a change in pull request #93:
URL: https://github.com/apache/hbase-connectors/pull/93#discussion_r812936682



##########
File path: pom.xml
##########
@@ -128,6 +128,15 @@
     <buildDate>${maven.build.timestamp}</buildDate>
     <compileSource>1.8</compileSource>
     <java.min.version>${compileSource}</java.min.version>
+    <!-- override on command line to have generated LICENSE files include
+         diagnostic info for verifying notice requirements -->
+    <build.year>2022</build.year>

Review comment:
       > In addition, I'm wondered if we need to add a generated NOTICE for 
modules of spark e.g. hbase-spark
   
   every artifact we create needs to have a proper LICENSE and NOTICE file. for 
the most part that should happen automatically for us unless we incorporate 
third party works in either the source or binary of an artifact.
   
   sorry for the lag, let me look again at what the current artifacts look like 
with this change in place.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to