busbey commented on pull request #93:
URL: https://github.com/apache/hbase-connectors/pull/93#issuecomment-1051639162
we're missing the part of the main project tooling that checks for problems
with the generated license:
```
(base) sbusbey@seans-mbp hbase-connectors-1.0.1-SNAPSHOT % grep -B 2
"^ERROR:" LICENSE.txt
This product includes Streaming API for XML licensed under the GNU General
Public Library.
ERROR: Please check ^^^^^^^^^^^^ this License for acceptability here:
```
stax-api is dual licensed GPL and CDDL. We'll also need to specify that
we're picking CDDL.
The generated NOTICE is missing the build year:
```
(base) sbusbey@seans-mbp hbase-connectors-1.0.1-SNAPSHOT % head -n 3
NOTICE.txt
Apache HBase Connectors - Assembly
Copyright 2018-${copyright-end-year} The Apache Software Foundation
```
It looks like this is because we need to activate the
`buildnumber-maven-plugin` in the `hbase-connectors-assembly` module. we only
define the version/configs in plugin management on the top level pom; we never
actually tell the plugin to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
