[ 
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290525#comment-13290525
 ] 

Zhihong Ted Yu commented on HBASE-6162:
---------------------------------------

The patch produces a lot of compilation errors:
{code}
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestProcessBasedCluster.java:[29,30]
 cannot find symbol
[ERROR] symbol  : class HTestConst
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java:[121,11]
 cannot find symbol
[ERROR] symbol  : variable LoadTestKVGenerator
[ERROR] location: class org.apache.hadoop.hbase.util.MultiThreadedWriter
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java:[128,58]
 cannot find symbol
[ERROR] symbol  : class LoadTestKVGenerator
[ERROR] location: class 
org.apache.hadoop.hbase.util.MultiThreadedWriter.HBaseWriterThread
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java:[191,24]
 cannot find symbol
[ERROR] symbol  : variable LoadTestKVGenerator
[ERROR] location: class 
org.apache.hadoop.hbase.util.MultiThreadedWriter.HBaseWriterThread
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java:[226,10]
 cannot find symbol
[ERROR] symbol  : variable LoadTestKVGenerator
[ERROR] location: class 
org.apache.hadoop.hbase.util.MultiThreadedReader.HBaseReaderThread
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java:[282,17]
 cannot find symbol
[ERROR] symbol  : variable LoadTestKVGenerator
[ERROR] location: class 
org.apache.hadoop.hbase.util.MultiThreadedReader.HBaseReaderThread
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestColumnRangeFilter.java:[192,24]
 cannot find symbol
[ERROR] symbol  : variable KeyValueTestUtil
[ERROR] location: class org.apache.hadoop.hbase.filter.TestColumnRangeFilter
[ERROR] 
[ERROR] 
/home/hduser/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java:[80,8]
 cannot find symbol
[ERROR] symbol  : variable KeyValueTestUtil
[ERROR] location: class org.apache.hadoop.hbase.regionserver.TestStoreScanner
{code}
                
> Move KeyValue to hbase-common module
> ------------------------------------
>
>                 Key: HBASE-6162
>                 URL: https://issues.apache.org/jira/browse/HBASE-6162
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6162-v1.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is 
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to 
> HConstants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to