[
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290744#comment-13290744
]
Matt Corgan commented on HBASE-6162:
------------------------------------
I think we are finally starting to grasp the problem Jesse =). That does suck.
Is there an alternative 1b: put the tests in
hbase-common/src/main/java/org/apache/hbase/test/{package}? At hotpads we even
put a lot of tests at the bottom of the class they're testing. I wouldn't care
between 1a and 1b, but perhaps 1b is more similar to the current system. For a
package like hbase-common where it's simple unit tests, anything should work ok.
One problem we'll run into with option 1a or 1b is that some of the tests
actually have a hidden dependency on the package they're in because they call
package-private constructors and methods on classes in their src/main package.
I personally don't like relying on package-private scope, especially across src
folders, so in my opinion option 1 would help us find and eliminate those
hidden dependencies.
> Move KeyValue to hbase-common module
> ------------------------------------
>
> Key: HBASE-6162
> URL: https://issues.apache.org/jira/browse/HBASE-6162
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Matt Corgan
> Assignee: Matt Corgan
> Fix For: 0.96.0
>
> Attachments: HBASE-6162-v1.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to
> HConstants
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
