[
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290833#comment-13290833
]
Matt Corgan commented on HBASE-6162:
------------------------------------
{quote}Why is KeyValueTestUtil going into hbase-common{quote}
Just the line of thinking that core, fundamental classes and their tests should
sit in hbase-common. I guess we could wait until things are explicitly needed
to pull them up, but the question i was asking myself was "if i'm writing hbase
from scratch and sketching out the necessary classes and modules, which module
would KeyValueTestUtil go into?". KeyValueTestUtil seemed to pass the
"fundamental" test. I suspect we'll need some other simple classes like this
up in hbase-common when we add the other modules, but i guess we can wait until
then to move them.
Thought it might help to move them earlier to simplify hbase-server.
{quote}An hbase-test that had test util under src/main would be OTT?{quote}
doesn't offend me, although if we're ok modifying the package names, it might
be easier to have less open projects in eclipse (less modules). either way, we
could consider it a temporary solution until maven is fixed.
> Move KeyValue to hbase-common module
> ------------------------------------
>
> Key: HBASE-6162
> URL: https://issues.apache.org/jira/browse/HBASE-6162
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Matt Corgan
> Assignee: Matt Corgan
> Fix For: 0.96.0
>
> Attachments: HBASE-6162-v1.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to
> HConstants
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
