comnetwork commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104874108
@Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but still invoke
`RegionReplicationSink.add`.
I think we could add an overload `MemStoreFlusher.requestFlush` to accept
the `writeFlushRequestWalMarker` paramter，just some modifications for
{{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to
not write WAL but still invoke `RegionReplicationSink.add`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
