Apache9 commented on code in PR #4355:
URL: https://github.com/apache/hbase/pull/4355#discussion_r861818360
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -2975,17 +2976,33 @@ private boolean isAllFamilies(Collection<HStore>
families) {
}
/**
- * Writes a marker to WAL indicating a flush is requested but cannot be
complete due to various
- * reasons. Ignores exceptions from WAL. Returns whether the write succeeded.
+ * This method is only used when we flush but the memstore is empty,if
writeFlushWalMarker is
+ * true,we write the {@link FlushAction#CANNOT_FLUSH} flush marker to WAL
when the memstore is
+ * empty. Ignores exceptions from WAL. Returns whether the write succeeded.
* @return whether WAL write was successful
*/
- private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean
writeFlushWalMarker) {
+ private boolean writeCanNotFlushMarkerToWAL(WriteEntry
flushOpSeqIdMVCCEntry, WAL wal,
Review Comment:
Good. The new method name is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
