Apache9 commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104879841
> @Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but still invoke
`RegionReplicationSink.add`.
>
> I think we could add an overload `MemStoreFlusher.requestFlush` to accept
the `writeFlushRequestWalMarker` paramter，just some modifications for
{{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to
not write WAL but still invoke `RegionReplicationSink.add`?
I think it is OK to not write the WAL but still add it to
RegionReplicationSink.
A problem for the old implementation of region replication is that, if users
use SKIP_WAL, then we can not do region replication any more. WIth the current
approach, since we do not need to read WAL from the file, it is OK for us to
send out WAL even if we do not want to write the WAL to file.
This one could a start. Later we could also try to see if the actual data
WAL can be replicated when SKIP_WAL is used.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
