[
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295812#comment-13295812
]
Matt Corgan commented on HBASE-6162:
------------------------------------
No worries stack - i just wasn't sure of the best approach for the tests so
decided to punt for now. I think we all agree they would be best in
hbase-common/src/test/java, but are foiled by maven again.
I actually tried putting them in
hbase-common/src/main/java/org/apache/hbase/test (removed hadoop package), but
it made for a very confusing package tree in eclipse since the non-test classes
were still in org/apache/hadoop/hbase. Looking at it made me think we should
drop the hadoop package for everything all at once and not move things
peicemeal.
It would be nice to pull the tests up somehow to help us untangle things...
what do you think is the best approach now? I can live with new modules, funny
package trees, etc. Just need to pick our poison i guess. I unfortunately
don't know enough about maven to even make a suggestion. You thinking an
hbase-common-tests module is the best approach for now?
> Move KeyValue to hbase-common module
> ------------------------------------
>
> Key: HBASE-6162
> URL: https://issues.apache.org/jira/browse/HBASE-6162
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Matt Corgan
> Assignee: Matt Corgan
> Fix For: 0.96.0
>
> Attachments: HBASE-6162-v1.patch, HBASE-6162-v2.patch,
> HBASE-6162-v3.patch, HBASE-6162-v4.patch, HBASE-6162-v5.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to
> HConstants
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
