[ 
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396003#comment-13396003
 ] 

Jesse Yates commented on HBASE-6162:
------------------------------------

-1 on an hbase-common-tests module until its really necessary. Generally, we 
should be able to split tests into two groups: (1) strict unit tests, (2) tests 
using the mini-cluster. 

Those with the mini-cluster should be somewhat refactored to test much of the 
same functionality, but with more mocking and smaller pieces. 

The bigger tests might need to be pulled into an hbase-tests module or 
hbase-{module}-tests module that depends on an hbase-test module. hbase-test 
would contain the mini-cluster, LargeTest, etc. and  also just depends on the 
_all_ hbase-{module} modules (so hbase-test depends on hbase-common, 
hbase-server, etc).
                
> Move KeyValue to hbase-common module
> ------------------------------------
>
>                 Key: HBASE-6162
>                 URL: https://issues.apache.org/jira/browse/HBASE-6162
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6162-v1.patch, HBASE-6162-v2.patch, 
> HBASE-6162-v3.patch, HBASE-6162-v4.patch, HBASE-6162-v5.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is 
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to 
> HConstants

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to