[
https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396128#comment-13396128
]
stack commented on HBASE-6162:
------------------------------
bq. Jesse - have you by chance tried getting tests to run when the test classes
are in src/main/java?
Why you ask Matt? Because if we have an hbase-tests, you think the tests
should go into src/main/java rather than into src/test/java?
bq. ...hbase-common/src/test/java, but are foiled by maven again.
If you put them there, aren't they run as part of the mvn test goal? (Or are
you trying to fix tests in a later module have dependency on code in
src/test/java in an earlier one?)
bq. Looking at it made me think we should drop the hadoop package for
everything all at once and not move things piecemeal.
That'll break the world unfortunately. We could do it internally but our
exterior APIs have the hadoop on them.... so we would have to do call through
from old APIs to the new ones. You don't think it ok just adding new stuff at
o.a.hbase? Maybe when we go to HBase 2.0?
bq. It would be nice to pull the tests up somehow to help us untangle things...
what do you think is the best approach now?
Yes... but regards the tests you included in earlier versions of the patch,
these were dirty because they had dependencies used by tests that were left
behind in hbase-server? I'd think the test needs teasing apart? Or would that
not work for the said test? Could the dependencies the test relies on be moved
into src/main/java..... tools?
Good on you Matt.
> Move KeyValue to hbase-common module
> ------------------------------------
>
> Key: HBASE-6162
> URL: https://issues.apache.org/jira/browse/HBASE-6162
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Matt Corgan
> Assignee: Matt Corgan
> Fix For: 0.96.0
>
> Attachments: HBASE-6162-v1.patch, HBASE-6162-v2.patch,
> HBASE-6162-v3.patch, HBASE-6162-v4.patch, HBASE-6162-v5.patch
>
>
> * pull KeyValue up to hbase-common module
> This is part of the modularization strategy in HBASE-5977, and is
> specifically necessary to modularize HBASE-4676.
> also brings these classes to hbase-common:
> * ClassSize, HeapSize
> * HTestConst
> * TestKeyValue, KeyValueTestUtil
> * LoadTestKVGenerator, TestLoadTestKVGenerator
> * MD5Hash
> moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to
> HConstants
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
