shahrs87 commented on code in PR #4556:
URL: https://github.com/apache/hbase/pull/4556#discussion_r903994074
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:
##########
@@ -1552,6 +1552,14 @@ public enum OperationStatusCode {
"hbase.regionserver.slowlog.systable.enabled";
public static final boolean DEFAULT_SLOW_LOG_SYS_TABLE_ENABLED_KEY = false;
+ @Deprecated
Review Comment:
> And why adding a deprecated field here? Just remove it?
We are replacing `hbase.slowlog.systable.chore.duration` with
`hbase.regionserver.named.queue.chore.duration`. Since the old config property
already exists, we will have to follow deprecation cycle.
> Better not adding more things to HConstants, please move then to a more
specific location.
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
