shahrs87 commented on code in PR #4556: URL: https://github.com/apache/hbase/pull/4556#discussion_r904067748
########## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationSinkTrackerTableCreator.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication.master; + +import static org.apache.hadoop.hbase.HConstants.NO_NONCE; + +import java.io.IOException; +import java.util.concurrent.TimeUnit; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.master.MasterServices; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * This will create {@link #REPLICATION_SINK_TRACKER_TABLE_NAME_STR} table if + * hbase.regionserver.replication.sink.tracker.enabled config key is enabled and table not created + **/ [email protected] +public final class ReplicationSinkTrackerTableCreator { + private static final Logger LOG = + LoggerFactory.getLogger(ReplicationSinkTrackerTableCreator.class); + private static final Long TTL = TimeUnit.DAYS.toSeconds(365); // 1 year in seconds Review Comment: We are using TTL.intValue below and that doesn't work with long primitive. We can always have the following statement but using TimeUnit util methods is more readable. Let me know if you want me to change to below. ``` private static final long TTL = 365 * 24 * 60; // 1 year in seconds ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
