shahrs87 commented on code in PR #4556:
URL: https://github.com/apache/hbase/pull/4556#discussion_r904192042
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java:
##########
@@ -178,6 +183,7 @@ protected final boolean addEntryToBatch(WALEntryBatch
batch, Entry entry) {
}
LOG.trace("updating TimeStampOfLastAttempted to {}, from entry {}, for
source queue: {}",
entry.getKey().getWriteTime(), entry.getKey(), this.source.getQueueId());
+ updateReplicationMarkerEdit(entry, batch.getLastWalPosition());
Review Comment:
We never add the marker row to the source cluster. It is directly injected
to the WAL of the source cluster. From WAL Event tracker, we know for each
region server which WAL is active and then we compare that with the marker rows
from the sink cluster. As a future work, I will add canary test which will run
periodically which will compare recent marker rows on the sink cluster with
the ACTIVE wal from the source cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
