bbeaudreault commented on PR #4592: URL: https://github.com/apache/hbase/pull/4592#issuecomment-1173111233
@Apache9 I've addressed your feedback. I also added a new TestByteBuffAllocatorLeakDetection. I think it seems pretty brittle, but it worked locally. I am not sure this test is worth it, because I anticipate it being a potential flake in the future and also having unintended consequences due to changing the InternalLogger. But wanted you guys to have something to look at. Let me know if that looks good to merge as is, or if you'd prefer I remove the new test. Or if any other comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
